Any ethers/cryptography expert?

How bad is that code?

https://gist.github.com/julien51/b72db711bda3e940afbe77c96d7d727d


I am trying to generate a private key consistently from a secret... (Complicated secret with upper/lower case numbers and symbols!)

Unlock Protocol founder.
Previously founder at Superfeedr (RSS push API) acquired by Medium!

https://ouvre-boite.com

Thanks Richard! 
It's fire something like this though: https://unlock-protocol.com/blog/password-required-hook do not meant to store value, but just a way to ensure onchain that someone knows of a secret.

Bad. I recall live demos of “brain wallets” being drained of BTC in like 2014, I’m sure it’s worse now. At least use significant key-stretching with scrypt. Check out: https://en.bitcoin.it/wiki/Brainwallet#Obsolete_Brainwallet_Style

BDFL of Quilibrium, Eng @ Farcaster, ex-Coinbase, always opinionated, never hydrated

/quilibrium

Ha! That's indeed a very good point. I should have clarified that this is not meant to be used to hold significant value in the long run... And indeed the user won't choose them.

Going to echo Ric here — hashing passwords directly for use as private keys is a really bad idea, because people tend to not remember strong passwords that can’t get churned out by hardware quickly. Once you hit the equivalent level of entropy of regular seed phrases, well, might as well just go back to mnemonics

ethers expert → @ricmoo 
cryptography expert → @cassie