timdaub pfp
timdaub
@timdaub.eth
@ricmoo I just saw that here and thought it was neat because I had run into ethers problems with it not being able to figure out the primary type: https://next.wagmi.sh/react/migration-guide#1xx-breaking-changes
1 reply
0 recast
1 reaction

RicMoo.eth pfp
RicMoo.eth
@ricmoo
It has to be computed anyway, and it represents a fatal mistake if there is a mismatch (usually it’s a typo or including the domain). I usually compare it to a PNG library that would require width, height *and* pixel count; it would be an error to mismatch any of those values. What was the problem you had?
1 reply
0 recast
0 reaction

RicMoo.eth pfp
RicMoo.eth
@ricmoo
(I have considered ignoring a type graph with exactly two roots, if one is the EIP712Domain and choosing the other as the primary type; feedback welcome ;))
0 reply
0 recast
0 reaction