Content
@
0 reply
0 recast
2 reactions
0xrusowsky
@0xrusowsky.eth
let's say that you are building a contract with the following properties: - never holds funds. all tokens are spent/sent back within the same tx. - interacts with aave pool (for flashloans)+ uniswap router as a dev, would you feel comfortable granting infinite approval to the aave/uni dependencies? why?
4 replies
0 recast
4 reactions
Mikko
@moo
There is zero reason for infinite approvals, including this one.
1 reply
0 recast
1 reaction
0xrusowsky
@0xrusowsky.eth
that's pretty much how i feel, too. but was wondering if it could make sense here as otherwise the contract will have to check the balances of different tokens and grand the approval on the go, incurring extra gas costs for each tx. i guess it's a fair compromise for peace of mind though haha
1 reply
0 recast
0 reaction