kompreni 🚂
@kompreni
@ampsfun is verrry interesting. I love that people can monetize their distribution independent of the platform (warpcast) I am unsure how the trust model will scale. Rn fc is a family. But at 10x? A single malicious txn can drain your wallet. The controls will make or break it. Congrats to the team on $30k!
2 replies
0 recast
13 reactions
Quazia
@quazia
afaik it also doesn't work with smart wallets due to it's reliance on `msg.sender` but they may have modified it since I last looked, so I'm not sure it'll work with coinbase wallet. Haven't tested this out yet but something worth looking into I reckon.
3 replies
0 recast
1 reaction
loudsqueak
@loudsqueak
ran some tests with a smart wallet and everything worked just fine! still some coinbase wallet specific things to fix (login flow sometimes works, sometimes doesn’t, difficult to debug) but other than that, should work closely to Warpcast where does msg.sender play into this? not familiar with that call
1 reply
0 recast
2 reactions
Quazia
@quazia
``` function disperseToken(IERC20 token, address[] recipients, uint256[] values) external { uint256 total = 0; for (uint256 i = 0; i < recipients.length; i++) total += values[i]; require(token.transferFrom(msg.sender, address(this), total)); for (i = 0; i < recipients.length; i++) require(token.transfer(recipients[i], values[i])); } function disperseTokenSimple(IERC20 token, address[] recipients, uint256[] values) external { for (uint256 i = 0; i < recipients.length; i++) require(token.transferFrom(msg.sender, recipients[i], values[i])); } ``` Lines 70 & 77 https://basescan.org/address/0x5e3c67ccb2615fe17033786a90bd2f99f3fc9f5e#code
1 reply
0 recast
2 reactions
loudsqueak
@loudsqueak
ah, thanks I did successfully interact with the contract with a smart wallet in cbw app but I’ll dig in closer here. Thanks for flagging
0 reply
0 recast
2 reactions