Uniswap

It appears that the token swap tool in the Uniswap wallet signs two transactions with only one user authentication.
I understand why they’ve done it but I personally find it scary. It breaches a social contract that existed since the early days of blockchains (one auth, one tx) and it doesn’t have a revoke tool.

eng @megaphone-hq | prev @0xproject | Interested in walkable cities

Thanks for the explanation, Phil. Uniswap approves an infinite amount, and I don’t think it’s too bad but I wish I could opt-out of the feature.

This is a common pattern. The Warpcast wallet, Metamask, Rabby, Coinbase Wallet and others all do this for their in wallet swaps

They typically set approval limits to the right amount so there should be nothing to revoke if the trade goes through

I do agree that they should make it clear that two txs are being signed at the same time

But this is not Uniswap wallet specific and it has been around for a very long time

sounds like eip 5792 support might help with this 

cc @philipliao.eth

@0xngmi And this is why I usually use @Rabby_io for swapping/bridging for small amounts. Glad to pay the 0.25% fee and bundle the approve/swap in 1 tx

One click approve and swap needs to be available everywhere, not an exclusive feature for a wallet’s in app swapper like in @Rabby_io @MetaMask and @CoinbaseWallet 

It can be done with EIP-5792 support at the wallet level

RT this for awareness

cc @WilsonCusack

Phil Liao (EIP-5792 maxi)

sounds like eip 5792 support might help with this 

cc @philipliao.eth 

https://x.com/philipliao_/status/1893016392582209950?s=46&t=O5FZeb4uTHbdw5tDIrRVPg

I don't think this bad since it improves UX imo. One of the things that attracted me to building on @starknet is the multicall ability. 

With that feature, users can use one Auth to sign multiple transactions, and the feedback on that from non-crypto natives have been impressive.