Content
@
https://opensea.io/collection/evm-6
0 reply
0 recast
2 reactions
nicholas 🧨
@nicholas
Solidity devs! Would anyone be up to take a look at the @crowdfund smart contract? Looking to get more eyes on it before launching a bunch more projects. https://github.com/seedclub/farcaster-crowdfund-contracts/blob/main/src/FarcasterCrowdfund.sol
3 replies
0 recast
6 reactions
0xmons
@xmon.eth
- can consider using enumerable address set to simplify donor management - a person running a crowdfund and always flash fill and claim even if the result isn't met (maybe acceptable logic violation)
1 reply
0 recast
1 reaction
0xbhaisaab
@0xbhaisaab
i would suggest each crowdfunding campaign should be its own separate contract, with a factory contract that creates and manages new ones. this way, every campaign has its own isolated treasury, which is much safer - if something goes wrong with one campaign, it won't affect the others and also more future proof.
1 reply
0 recast
0 reaction
maks
@maks
Some minor stuff on very quick review: Why 721 instead of 1155 for commemorative NFT? If using 1155, `tokenId` can equal `crowdFundId` and can kill `tokenToCrowdfund` mapping. 1155 feels more appropriate for use case. Also not sure of reason for `donorToTokenId` mapping, can use donation amount (>0) to check if previously donated. Can use a Bitmap for the bool mappings. Can use named parameters in mappings. Also would consider letting crowdfund creator transfer "ownership" rights. I like the comments "requirements" section. 😀
0 reply
0 recast
0 reaction
