Ruslan Valeev pfp

Ruslan Valeev

@max-max

75 Following
5 Followers
Ruslan Valeev pfp
Ruslan Valeev
@max-max
Native env
0 reply
0 recast
1 reaction
Ruslan Valeev pfp
Ruslan Valeev
@max-max
that was the issue. lastTicks[key.toId()] = tickAfterExecutingOrder should be out of the loop in afterSwap() function (in the lesson it was inside). Thank you so much @haardikkk šŸ™
1 reply
0 recast
1 reaction
Ruslan Valeev pfp
Ruslan Valeev
@max-max
if you mean `lib/v4-periphery/lib/v4-core/src/test/PoolSwapTest.sol` and 97 and 98 rows. But in my file this two rows are on 69 and 70 rows respectively. And I commented them and all the other 5 tests passed (including two from part 1). Maybe here is the reason and my library is another version?
0 reply
0 recast
0 reaction
Ruslan Valeev pfp
Ruslan Valeev
@max-max
Hi guys! Does anyone have already tried to run the code from today's lesson? I have one failed test there (test_multiple_orderExecute_zeroForOne_both - last assert with 60 tick: [FAIL. Reason: assertion failed: 10000000000000000 != 0] test_multiple_orderExecute_zeroForOne_both() (gas: 612203). Has anyone got this too?
1 reply
0 recast
1 reaction