Content
@
https://opensea.io/collection/dev-21
0 reply
0 recast
2 reactions
Jacek.degen.eth π©
@jacek
If you're a Solidity dev and interested in helping out Degen by auditing or reviewing our Locked Degen ERC-20 contract, we'd love your support. Your help in finding bugs or suggesting code improvements would be greatly appreciated! Thanks! https://github.com/degen-token/degen-smart-contracts/pull/22
29 replies
35 recasts
211 reactions
J. Valeska π¦π©π«
@jvaleska.eth
some people is asking about it.. and I had to stop my audit.. after found it.. LN 130 - updateLockDuration() function This allow the owner to change the locking period.. between 0-365 days. LN 118 - if (block.timestamp <= depositTimestamps[msg.sender] + lockDuration) revert... This check on lockDuration in the withdraw function allows the owner to do some tricks with the locking period: - the owner could lock and unlock by managing to do a sandwich: updateLockFunction-withdraw-updateLockFunction, withdrawing without respecting the lock. And, setting it again locking users funds. - the owner could extend the locking period, from an initial 0 days to 1 year. Locking user funds for 1 year without user "permission".
13 replies
0 recast
6 reactions
Jacek.degen.eth π©
@jacek
Also, once the new season kicks off, I'll tip you. I've fallen behind on my tipping lately, and now I'm down to a 5-tip limit, lol. This season seriously needs an upgrade. Sending 5 $DEGEN for now.
9 replies
0 recast
11 reactions
J. Valeska π¦π©π«
@jvaleska.eth
LOL (agreed, this season is being "rare") No need for tips but they are appreciated π© In addition, I have found the contract very simple and with no extra complications, it does exactly what it needs to do and nothing more, and it is following battle tested standards like the reentrant modifier to protect against reentrancy attacks. Feels safe.
0 reply
0 recast
0 reaction
