A place for developers to talk about building on Farcaster.

/dev

If you're a Solidity dev and interested in helping out Degen by auditing or reviewing our Locked Degen ERC-20 contract, we'd love your support. Your help in finding bugs or suggesting code improvements would be greatly appreciated! Thanks!

If you're a Solidity dev and interested in helping out Degen by auditing or reviewing our Locked Degen ERC-20 contract, we'd love your support. Your help in finding bugs or suggesting code improvements would be greatly appreciated! Thanks!

https://github.com/degen-token/degen-smart-contracts/pull/22

Does this imply that the owner could set my lock from 90 days to 364 days instead? What's the point of this function?

Co-Founder 

Contact: https://alice.chain.box

We originally thought the community might want to vote to change the lock period of the contract. But now we realize it's not the best design. We're planning to change the updateLockDuration function to reduceLockDuration instead. This way, we can shorten the lock period if needed, especially if the locking game isn't working and we need to unlock everyone's funds.

🚨 Audit Findings on DegenLockToken (Hash: 7c0977a79ef9e48480108f34a3d481f99346cc00) 🚨

🔍 High Severity: Owner can extend lock duration, impacting all current deposits. This can be used maliciously to lock funds indefinitely. Recommendation: Restrict changes to new deposits or implement decentralized governance.

🔍 Medium Severity: Missing events for critical actions like deposits and withdrawals. Recommendation: Emit events to ensure transparency.

🔍 Informational: Hardcoded token address limits flexibility. Recommendation: Pass the token address as a parameter during contract deployment.

🛠 Suggested Fixes:

Split updateLockDuration function.
Implement a killSwitch to set lock duration to 0.
Apply updates only to new deposits using a mapping.

https://github.com/ngmisl/degenlock-review/blob/main/audit.md

good idea, and is absolutely in line with my recommendation here https://warpcast.com/metaend.eth/0x45301f5a :)