Content
@
0 reply
0 recast
0 reaction
Goksu Toprak
@gt
*Who wants to land this update for Warpcast for Rewards frame?* Upgrade to 0.0.20 and disable the safe area inserts. I'll review and approve if done today. (Will implement it myself if no one gets to it today) https://github.com/warpcast/scores-frame/issues/38
1 reply
21 recasts
71 reactions
dylan
@dylsteck.eth
just put up a small pr! https://github.com/warpcast/scores-frame/pull/39
1 reply
3 recasts
7 reactions
Goksu Toprak
@gt
Thanks! Looks good! Are you able to land it? I am not sure if the permissions allow you to actually land the change. Let me know.
1 reply
0 recast
3 reactions
pugson
@pugson
before you merge this: margins will cause overflow in some scenarios and layout shift. gotta use padding for the edges
2 replies
0 recast
6 reactions
dylan
@dylsteck.eth
ah nice, that makes sense β was just following the example code lol. gonna go tweak that! π
1 reply
0 recast
1 reaction
dylan
@dylsteck.eth
just made the tweak, looks like there's some maintainer access needed to merge the pr though
0 reply
0 recast
1 reaction