Content
@
https://uniswap.org
0 reply
0 recast
0 reaction
Patricio Worthalter
@worthalter
It appears that the token swap tool in the Uniswap wallet signs two transactions with only one user authentication. I understand why they’ve done it but I personally find it scary. It breaches a social contract that existed since the early days of blockchains (one auth, one tx) and it doesn’t have a revoke tool.
3 replies
12 recasts
69 reactions
Phil Liao
@philipliao.eth
This is a common pattern. The Warpcast wallet, Metamask, Rabby, Coinbase Wallet and others all do this for their in wallet swaps They typically set approval limits to the right amount so there should be nothing to revoke if the trade goes through I do agree that they should make it clear that two txs are being signed at the same time But this is not Uniswap wallet specific and it has been around for a very long time
2 replies
1 recast
5 reactions
Patricio Worthalter
@worthalter
Thanks for the explanation, Phil. Uniswap approves an infinite amount, and I don’t think it’s too bad but I wish I could opt-out of the feature.
1 reply
0 recast
3 reactions
Phil Liao
@philipliao.eth
The infinite approval is a suboptimal implementation of this. None of the other wallets set infinite approvals to my understanding Do you know if the infinite approval is set on Permit2? If so, it may not be as bad as it appears But I know Uniswap also sets time bound infinite approvals via Permit2 which are not great, but mitigates the risk significantly
1 reply
1 recast
3 reactions
