Foundry

What are best practices for custom errors?
- When should they include arguments?
- Should there be many diff error types or more generic errors that accept arguments to differentiate error cases?

Always favor multiple error types over using an enumeration as an argument. Arguments are for free-form data that can't be known at compile time.

Provide information useful to someone who can't see your contract's state or source code. Don't repeat transaction information they already have.

As long as you have enough space in the contract, I'd go for more verbose/specialised errors, as it makes it easier for a third-party to diagnose the cause of the error. I've also started putting the errors (alongside other functions, state variable functions, etc) into an interface, to save devs having to import the implementation.