Content pfp
Content
@
0 reply
0 recast
0 reaction

Devin Conley pfp
Devin Conley
@conley
Bug bounty for a single solidity contract that handles receiving (buying) and reselling 721s and 1155s via dutch auction in shuffled bundles Payout: 100 usdc for any logical bug or significant gas optimization Deadline: 2023/12/22 Repo: https://github.com/devinaconley/garage-sale @bountybot
6 replies
0 recast
2 reactions

Timmy🎩🐹⬆🕵️‍♂️ pfp
Timmy🎩🐹⬆🕵️‍♂️
@timmykwesi.eth
Great one. I'll see what I can find 🔍
2 replies
0 recast
1 reaction

Timmy🎩🐹⬆🕵️‍♂️ pfp
Timmy🎩🐹⬆🕵️‍♂️
@timmykwesi.eth
On line 455, the emit event happens within the for loop. Usually, you'd want to emit an event only once at the end of the loop.
1 reply
0 recast
1 reaction

Timmy🎩🐹⬆🕵️‍♂️ pfp
Timmy🎩🐹⬆🕵️‍♂️
@timmykwesi.eth
Also, custom errors are more gas-efficient than using require/assert. The use of unchecked for incrementing in loops could save substantial amount gas too. i.e. ```for(uint256 i; i < length;) { unchecked{ ++i; }``` These are the lines that could make use of that: [175, 235, 252, 317, 431].
1 reply
0 recast
1 reaction