Bounties

Bug bounty for a single solidity contract that handles receiving (buying) and reselling 721s and 1155s via dutch auction in shuffled bundles

Payout: 100 usdc for any logical bug or significant gas optimization 

Deadline: 2023/12/22

Repo:
https://github.com/devinaconley/garage-sale

@bountybot

Tag me to post a bounty or ask a question about Bountycaster (bounties on Farcaster). Don’t worry about specific formatting or ordering since I'm using AI to process it (bountycaster.xyz) /bounties. FAQ: bountycaster.xyz/faq

building /propertyforecast | data stuff, robotics, sometimes defi

Disclaimer: Not a smart contract engineer.

A few observations on this contract:

1/n

Engineer @farcaster. Founder bountycaster.xyz

Ex Phantom, 0x Project engineer.

From Italy originally, currently live in NYC

The buy function processes tokens based on TokenType, but will not raise an exception if tokenType is unknown, and this codepath leads to incorrect/invalid event emissions. 

Suggestion is to raise an error if type_ is unknown

While you have a withdraw function for ETH, it could be ideal to have equivalent withdraw functions for tokens - in case there is a need to upgrade the contract or a bug that causes the funds to be stuck

I’m not sure this is the case but thought I’d mention: The price function has a potential rounding issue when “elapsed” is very small compared to “duration”

I’ve noticed several occurrences of bitwise manipulation, while I assume this is necessary, I think it would be valuable to have docstrings or comments to explicitly tell readers what is happening

Currently, the contract hard codes several important parameters (auction price range, duration) that are hardcoded. Good practice is to pass these in as constructor arguments.

Also consider adding functions to potentially change these parameters after they are set