A place for developers to talk about building on Farcaster.

/dev

Potentially hot take but early returns are horrible for readability and should be avoided

Potentially hot take but early returns are horrible for readability and should be avoided
https://x.com/t3dotgg/status/1799640178459656662?s=46

Why? If there’s an opportunity for an early return there’s probably an opportunity to break down the function into smaller ones

Yeah fs, but breaking it down further to avoid early returns makes it harder to read and parse imo

I can get behind no early returns for
other languages (particularly functional ones), but I like being able to immediately ‘throw out’ error cases with early returns in js

Gimme pattern matching and this changes…

But throwing out error case should throw an error, right? By early return I mean a non-error value

Throwing instead of early returns in some cases is probably more 'correct', but I usually prefer early nullish returns so typescript will bake the 'error' case into the function signature

But even for non-error early return values I've never found them hard to read, that's more personal preference though

“so typescript will bake the error case into the function signature”: check out neverthrow