Content
@
https://opensea.io/collection/dev-21
0 reply
0 recast
2 reactions
Jacek.degen.eth 🎩
@jacek
If you're a Solidity dev and interested in helping out Degen by auditing or reviewing our Locked Degen ERC-20 contract, we'd love your support. Your help in finding bugs or suggesting code improvements would be greatly appreciated! Thanks! https://github.com/degen-token/degen-smart-contracts/pull/22
29 replies
35 recasts
211 reactions
0xteresa🎩
@0xteresa.eth
I made a quick check and I didn’t see that there is a mapping to track the amount of DEGEN that users deposit, you only mint the new tokens. After that to withdraw you burn these new tokens, but what happens if the user gets more “new tokens” in not an honest way or buying them in the market? They will be able to unlock the real DEGEN tokens locked in the contract because you don’t track the real owner in your contract.
1 reply
0 recast
3 reactions
Jacek.degen.eth 🎩
@jacek
That can't happen since Locked Degen tokens are non-transferable. They can only be held by the wallet that originally minted them by locking Degen. So, there's no way for someone to get Locked Degen tokens without actually locking their own Degen first.
2 replies
0 recast
1 reaction
0xteresa🎩
@0xteresa.eth
If someone locks today an amount of DEGEN and in some days the same person decides to lock more DEGEN, the mapping of the block timestamp for the msg.sender will be updated with the last time that the user locked for all the amount of DEGEN (the one locked at the begining and later). Is that on purpose?
1 reply
0 recast
0 reaction
Jacek.degen.eth 🎩
@jacek
Yes, we'll make sure to clarify this in the instructions. Basically, you can only extend your existing lock; you can't set up two separate locks with the same wallet address. We might introduce a second lock contract for 1-year locks though.
0 reply
0 recast
1 reaction
